#4612: Improve sanitizing column headers and description for datastore import#4613
Open
stefan-korn wants to merge 1 commit intoGetDKAN:2.xfrom
Open
#4612: Improve sanitizing column headers and description for datastore import#4613stefan-korn wants to merge 1 commit intoGetDKAN:2.xfrom
stefan-korn wants to merge 1 commit intoGetDKAN:2.xfrom
Conversation
janette
reviewed
Feb 27, 2026
| * sanitized column name on single line. | ||
| */ | ||
| public static function sanitizeDescription(string $column) { | ||
| $column = preg_replace('~[^\x20-\x7E\t\r\n]~', '_', $column); |
Member
There was a problem hiding this comment.
@stefan-korn seems like it would be better to just remove the BOM rather than replace it with an underscore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4612
Describe your changes
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation