Skip to content

chore: remove dead tasksRecorded field from RunPlanOutcome#598

Open
Ritvvvik wants to merge 1 commit into
GetBindu:mainfrom
Ritvvvik:fix/tasks-recorded-dead-code
Open

chore: remove dead tasksRecorded field from RunPlanOutcome#598
Ritvvvik wants to merge 1 commit into
GetBindu:mainfrom
Ritvvvik:fix/tasks-recorded-dead-code

Conversation

@Ritvvvik

@Ritvvvik Ritvvvik commented Jul 24, 2026

Copy link
Copy Markdown

Removes the dead \ asksRecorded\ field from \RunPlanOutcome\ and its return-path plumbing.

References: \known-issues.md\ entry \ asks-recorded-is-dead-state.

Summary by CodeRabbit

  • Breaking Changes
    • Planner outcomes no longer include the tasksRecorded field.
    • Applications consuming runPlan or startPlan responses should rely on the returned message instead.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c5de0f3-2591-4e06-92ca-cbe3e3bc958e

📥 Commits

Reviewing files that changed from the base of the PR and between 7b1ff75 and 98e6054.

📒 Files selected for processing (1)
  • gateway/src/planner/index.ts

📝 Walkthrough

Walkthrough

Changes

Planner outcome simplification

Layer / File(s) Summary
Remove tasksRecorded from planner outcomes
gateway/src/planner/index.ts
The public outcome interface and planner success return paths no longer include or forward tasksRecorded.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: raahulrahl

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits the required template sections like summary, change type, verification, and security impact. Rewrite the PR description using the repository template, filling in the required sections for summary, change type, scope, verification, and risks.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: removing the dead tasksRecorded field.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Ritvvvik
Ritvvvik force-pushed the fix/tasks-recorded-dead-code branch from 42ccf3e to 98e6054 Compare July 24, 2026 13:53
@Ritvvvik
Ritvvvik marked this pull request as ready for review July 24, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant