Support review apps for rapgenius #14
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the bookmarklet needs it in order to determine the latest version. So, we'll just do it a bit earlier than normal.
RDIL
added a commit
to RDIL/modern_searchlogic
that referenced
this pull request
Aug 23, 2025
In a test environment, or when creating/seeding the database, there are no tables defined in ActiveRecord. This causes an edge case where, if *any* `method_missing` is called (and it gets to MSL), an error will be thrown. This is because accessing `columns_hash` or `column_names` will cause a query to be made that will fail (as it expects the table to already be present in the database). For getting caught up on the memes, see the following: - Genius/Rap-Genius#15200 - Genius/heroku-buildpack-ruby#14 Feel free to backport this to Rails 2 - seems pointless since it's On The Way Out (TM) (as it has been for the last decade, but who's counting?!)
RDIL
added a commit
to RDIL/modern_searchlogic
that referenced
this pull request
Aug 23, 2025
In a test environment, or when creating/seeding the database, there are no tables defined in ActiveRecord. This causes an edge case where, if *any* `method_missing` is called (and it gets to MSL), an error will be thrown. This is because accessing `columns_hash` or `column_names` will cause a query to be made that will fail (as it expects the table to already be present in the database). For getting caught up on the memes, see the following: - Genius/Rap-Genius#15200 - Genius/heroku-buildpack-ruby#14 Feel free to backport this to Rails 2 - seems pointless since it's On The Way Out (TM) (as it has been for the last decade, but who's counting?!)
RDIL
added a commit
to RDIL/modern_searchlogic
that referenced
this pull request
Aug 27, 2025
In a test environment, or when creating/seeding the database, there are no tables defined in ActiveRecord. This causes an edge case where, if *any* `method_missing` is called (and it gets to MSL), an error will be thrown. This is because accessing `columns_hash` or `column_names` will cause a query to be made that will fail (as it expects the table to already be present in the database). For getting caught up on the memes, see the following: - Genius/Rap-Genius#15200 - Genius/heroku-buildpack-ruby#14 Feel free to backport this to Rails 2 - seems pointless since it's On The Way Out (TM) (as it has been for the last decade, but who's counting?!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: Rap-Genius#15200
Here's the situation:
The normal flow goes:
Ideally, we'd seed the database after precompiling assets, as the first of the compile tasks.
BUT, one of the bookmarklet ERB templates makes a DB connection, and errors when seeding has not happened yet!
I considered using another buildpack, but the ruby buildpack installs gems and precompiles, meaning there is no "wiggle room" in between those two to insert a new buildpack. Hence, I've forked the existing one.