Add AccessControl timeline provider sample#164
Open
alafleur-genetec wants to merge 3 commits intomainfrom
Open
Add AccessControl timeline provider sample#164alafleur-genetec wants to merge 3 commits intomainfrom
alafleur-genetec wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new AccessControl timeline provider sample to demonstrate how to create and register timeline providers in the Workspace SDK. The changes include a new timeline provider for displaying access control events alongside the existing alarm timeline provider.
Changes:
- Added AccessControl timeline provider components (builder, provider, and event classes)
- Updated the module registration to handle multiple timeline providers with proper initialization and cleanup
- Improved resource management by implementing IDisposable pattern for both timeline providers
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SampleModule.cs | Refactored to register both alarm and access control timeline providers with proper cleanup in Unload |
| AlarmTimelineProviderBuilder.cs | Added clarifying comment for UniqueId GUID and reordered using statements |
| AlarmTimelineProvider.cs | Implemented IDisposable for proper event handler cleanup and moved event handler to a separate method |
| AccessControlTimelineProviderBuilder.cs | New builder class for AccessControl timeline provider |
| AccessControlTimelineProvider.cs | New provider class that queries and displays access control events |
| AccessTimelineEvent.cs | New event class for rendering access control events on the timeline |
| Genetec.Dap.CodeSamples.AccessControlTimelineProviderBuilder.cert | Certificate file for the new AccessControl timeline provider |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add proper component unregistration in SampleModule.Unload() - Add error handling with MessageBox in SampleImageExtractor - Fix VCardReader to correctly extract FirstName from N: field - Make photo regex more flexible for different vCard formats
This reverts commit 423b09a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.