Fix race conditions in ArchiveFileSystem #313
Open
+17
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CLIENT-3AB. The issue was that: Unprotected concurrent multimap access during file existence checks and texture reprioritization causes hash table corruption and access violation.
FastCriticalSectionClassmutex (m_archiveDirectoryMutex) toArchiveFileSystemto protect its internal directory structure and nested elements.loadIntoDirectoryTree,doesFileExist,friend_getArchivedDirectoryInfo, andgetArchiveFileto ensure thread-safe access to the archive directory.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 9526657
Not quite right? Click here to continue debugging with Seer.