Skip to content

Conversation

@seer-by-sentry
Copy link

Fixes CLIENT-34G. The issue was that: D3DXLoadSurfaceFromSurface receives NULL surface pointer because GetSurfaceLevel's return value is unchecked, leading to access violation.

  • Added null checks for the input 'surface' parameter in '_Create_DX8_Texture'.
  • Implemented checks for successful texture creation after calling '_Create_DX8_Texture'.
  • Added error handling and null checks for 'GetSurfaceLevel' calls in '_Create_DX8_Texture' and 'MissingTexture::_Init'.
  • Improved the robustness of Direct3D texture and surface operations by logging errors and returning a missing texture on failure.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 9159096

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants