Skip to content

Prevent null command button assignment from control bar override #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent null command button assignment from control bar override #295

seer-by-sentry wants to merge 1 commit into from

Conversation

@seer-by-sentry
Copy link

@seer-by-sentry seer-by-sentry bot commented Jan 25, 2026

Fixes CLIENT-2X4. The issue was that: Null CommandButton from m_controlBarOverrides is dereferenced in Object::canProduceUpgrade via CommandSet::getCommandButton.

  • Added a null pointer check for the command button retrieved from 'm_controlBarOverrides'.
  • Ensures that 'commandButton' is only assigned if the override exists and its value is not null.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 9153349

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant