Skip to content

Fix libcurl 8.6.0 Schannel division by zero #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix libcurl 8.6.0 Schannel division by zero #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameNetwork/GeneralsOnline/HTTP/HTTPRequest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ void HTTPRequest::PlatformStartRequest()
curl_easy_setopt(m_pCURL, CURLOPT_SSL_VERIFYHOST, 0);
#endif

// Explicitly set supported elliptic curves for Schannel to prevent division by zero
// in CTlsExtServer::ParseEllipticCurveExtension when using libcurl 8.6.0 with Schannel
curl_easy_setopt(m_pCURL, CURLOPT_SSL_EC_CURVES, "X25519:P-256:P-384:P-521");


}
}
7 changes: 6 additions & 1 deletion ...alsMD/Code/GameEngine/Source/GameNetwork/GeneralsOnline/OnlineServices_RoomsInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ void WebSocket::Connect(const char* url, bool bIsReconnect, std::function<void(v
curl_easy_setopt(m_pCurlWS, CURLOPT_SSL_VERIFYPEER, 0);
curl_easy_setopt(m_pCurlWS, CURLOPT_SSL_VERIFYHOST, 0);
#endif

// Explicitly set supported elliptic curves for Schannel to prevent division by zero
// in CTlsExtServer::ParseEllipticCurveExtension when using libcurl 8.6.0 with Schannel
curl_easy_setopt(m_pCurlWS, CURLOPT_SSL_EC_CURVES, "X25519:P-256:P-384:P-521");



// ws needs auth
Expand Down Expand Up @@ -1361,4 +1366,4 @@ void NGMP_OnlineServices_RoomsInterface::OnRosterUpdated(std::vector<std::string
{
m_RosterNeedsRefreshCallback();
}
}
}
Expand Down
Loading