fix(website): replace incorrectly hardcoded lapis filter with correctly parameterized filter #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fhennig
force-pushed
the
fix-hardcoded-pango-lineage
branch
from
32e996f to
146e26b
Compare
fhennig
force-pushed
the
fix-hardcoded-pango-lineage
branch
from
146e26b to
c0a5ed2
Compare
…ly parameterized filter
fhennig
force-pushed
the
fix-hardcoded-pango-lineage
branch
from
c0a5ed2 to
c8893af
Compare
1 task
Contributor
|
Can't really judge whether it works though without #945, but let's get both merged and then check again. RSV won't be live yet anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Another case of an overlooked hardcoded field name.
Found by fengelniederhammer here: #945 (review)
PR Checklist