feat(website): submit filters with one button click #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2024
fengelniederhammer
requested changes
Nov 12, 2024
website/src/components/pageStateSelectors/ApplyFilterButton.tsx
Outdated
Show resolved
Hide resolved
website/src/components/pageStateSelectors/SingleVariantPageStateSelector.tsx
Show resolved
Hide resolved
JonasKellerer
force-pushed
the
35-submit-button-for-search-requires-2-actions-instead-of-1-to-submit---this-is-confusing
branch
2 times, most recently
from
d76f444 to
18f460f
Compare
JonasKellerer
force-pushed
the
35-submit-button-for-search-requires-2-actions-instead-of-1-to-submit---this-is-confusing
branch
from
18f460f to
ff59a2f
Compare
fengelniederhammer
approved these changes
Nov 14, 2024
website/src/components/pageStateSelectors/CompareSideBySidePageStateSelector.tsx
Outdated
Show resolved
Hide resolved
website/src/components/pageStateSelectors/SingleVariantPageStateSelector.tsx
Outdated
Show resolved
Hide resolved
JonasKellerer
force-pushed
the
35-submit-button-for-search-requires-2-actions-instead-of-1-to-submit---this-is-confusing
branch
from
00d20cc to
9d576e3
Compare
JonasKellerer
deleted the
35-submit-button-for-search-requires-2-actions-instead-of-1-to-submit---this-is-confusing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35
resolves #35
Summary
The construction of the filters for baseline and variants is now performed client-side. This way, we no longer need different buttons to filter for each of them.
In this PR, I also use the new way to provide date ranges to the range selector component.
Screenshot
Single variant page
Sequencing efforts page
Compare side by side page
