219 clickable mega menu navigation #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice css magic :) Maybe we could also color the overlay slightly gray, to indicate that the user has to click outside. I also found this on other pages using mega menus |
fengelniederhammer
force-pushed
the
219-clickable-mega-menu-navigation
branch
from
a9d161b to
99ea98a
Compare
JonasKellerer
suggested changes
Nov 12, 2024
Contributor
JonasKellerer
left a comment
JonasKellerer
left a comment
There was a problem hiding this comment.
I like it. Looks great.
For me, the gray background does not work.
JonasKellerer
approved these changes
Nov 14, 2024
Contributor
JonasKellerer
left a comment
JonasKellerer
left a comment
There was a problem hiding this comment.
Only two minor improvements.
fengelniederhammer
force-pushed
the
219-clickable-mega-menu-navigation
branch
from
a353765 to
d72703b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #219
Summary
The code isn't pretty yet, but before doing that, I'd like feedback whether the solution is good enough.
I tried to stick to having a statically rendered menu (no JS there on client side)
Screenshot
Bildschirmaufzeichnung.vom.07.11.2024.14.51.13.webm