Skip to content

Conversation

@fengelniederhammer
Copy link
Contributor

resolves #1423

PR Checklist

- [ ] All necessary documentation has been adapted.

  • The implemented feature is covered by an appropriate test.

@vercel
Copy link

vercel bot commented Dec 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lapis Ready Ready Preview Comment Dec 11, 2025 10:21am

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables a previously skipped end-to-end test that was failing due to Node.js's fetch automatically decompressing zstd responses as of version 24. The test now verifies the decompressed content instead of checking for zstd encoding.

  • Removed the it.skip wrapper to re-enable the test
  • Updated test assertions to validate decompressed content based on response type (SEQUENCES, TREE, or METADATA)
  • Added a comment explaining the behavioral change in Node.js 24

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

There is no change in the changelog. This PR will not produce a new releasable version.

@fhennig
Copy link
Contributor

fhennig commented Dec 11, 2025

Ohh, great that you found out what the issue was! But I'm not sure that the test is useful now, because how does it distinguish between

  • the compression was automatically decompressed by fetch
  • there was no compression in the first place
    ?

@fengelniederhammer
Copy link
Contributor Author

Ohh, great that you found out what the issue was! But I'm not sure that the test is useful now, because how does it distinguish between

* the compression was automatically decompressed by fetch

* there was no compression in the first place
  ?

The response headers are still a good indication. And it's still better than not testing this at all.

@fhennig
Copy link
Contributor

fhennig commented Dec 11, 2025

Ah I didn't realize/read well enough, that we check the headers. Ok then! LGTM

@fengelniederhammer fengelniederhammer merged commit c1a067d into main Dec 15, 2025
9 checks passed
@fengelniederhammer fengelniederhammer deleted the 1423-ci-zstd-compression-via-header-doesnt-work branch December 15, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: zstd compression via header doesn't work

3 participants