-
Notifications
You must be signed in to change notification settings - Fork 6
chore(lapis-e2e): reenable test that broke since fetch automatically decompresses zstd now #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lapis-e2e): reenable test that broke since fetch automatically decompresses zstd now #1479
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR re-enables a previously skipped end-to-end test that was failing due to Node.js's fetch automatically decompressing zstd responses as of version 24. The test now verifies the decompressed content instead of checking for zstd encoding.
- Removed the
it.skipwrapper to re-enable the test - Updated test assertions to validate decompressed content based on response type (SEQUENCES, TREE, or METADATA)
- Added a comment explaining the behavioral change in Node.js 24
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There is no change in the changelog. This PR will not produce a new releasable version. |
1b0b25d to
2378198
Compare
|
Ohh, great that you found out what the issue was! But I'm not sure that the test is useful now, because how does it distinguish between
|
The response headers are still a good indication. And it's still better than not testing this at all. |
|
Ah I didn't realize/read well enough, that we check the headers. Ok then! LGTM |
resolves #1423
PR Checklist
- [ ] All necessary documentation has been adapted.