Skip to content

Fix(chat): resolve missing None-guard in _call_start_workflow crashing on both fields absent #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jean-Regis-M wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(chat): resolve missing None-guard in _call_start_workflow crashing on both fields absent #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions finbot/agents/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ async def _call_start_workflow(
invoice_id: int | None = None,
attachment_file_ids: list[int] | None = None,
) -> str:
if description is None or vendor_id is None:
return json.dumps({"error": "description and vendor_id are required"})

if not self.background_tasks:
return json.dumps({"error": "Workflow engine not available"})

Expand Down
Loading