Skip to content

Fix(finmail): resolve unbounded sender_name storage with length guard #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jean-Regis-M wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(finmail): resolve unbounded sender_name storage with length guard #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion finbot/mcp/servers/finmail/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@

logger = logging.getLogger(__name__)

MAX_SENDER_NAME = 100

DEFAULT_CONFIG: dict[str, Any] = {
"max_results_per_query": 50,
"default_sender": "OWASP FinBot",
Expand Down Expand Up @@ -96,8 +98,9 @@ def send_email(
effective_sender = sender_name or config.get(
"default_sender", "OWASP FinBot"
)
if len(effective_sender) > MAX_SENDER_NAME:
return {"error": f"sender_name exceeds maximum length of {MAX_SENDER_NAME} characters"}
inv_id = related_invoice_id if related_invoice_id > 0 else None

if _is_vendor_session(session_context):
from_addr = _get_vendor_email(session_context) or get_admin_address(
session_context.namespace
Expand Down
Loading