Skip to content

Update license codelist and schema format#373

Merged
duncandewhurst merged 12 commits into1.0-devfrom
123-update-license-codelist
Mar 5, 2026
Merged

Update license codelist and schema format#373
duncandewhurst merged 12 commits into1.0-devfrom
123-update-license-codelist

Conversation

@odscrachel
Copy link
Copy Markdown
Contributor

@odscrachel odscrachel commented Feb 12, 2026

Related issues

Closes #123
Closes #281

Description

Outstanding questions @duncandewhurst

  • is the description in the schema still okay as it is?
  • will we update the examples now or do them at once, given a lot will change?

Merge checklist

If you added, removed or renamed a field:

  • Update the collapse option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss on reference/schema.md
  • Update the diagrams in reference/schema/md
  • Update the JSON files in examples

Always:

  • Run ./manage.py pre-commit
  • Update the changelog (style guide)

Having trouble?

See how to resolve check failures.

@odscrachel odscrachel force-pushed the 123-update-license-codelist branch from 8e34dd3 to 18242f9 Compare February 12, 2026 14:38
@odscrachel odscrachel marked this pull request as draft February 12, 2026 14:53
Copy link
Copy Markdown
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested updates to the description. We can leave updating the examples until all the schema and codelist changes are merged.

Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/codelists/open/license.csv Outdated
Comment thread schema/rdls_schema.json Outdated
@odscrachel odscrachel marked this pull request as ready for review February 24, 2026 12:48
@duncandewhurst
Copy link
Copy Markdown
Contributor

@odscrachel can we use this same PR to address #281? That way we can implement a shared definition for license and reuse it in both places.

Copy link
Copy Markdown
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two outstanding suggestions from my previous review also need to be addressed.

@duncandewhurst
Copy link
Copy Markdown
Contributor

@odscrachel I deleted the suggestion from my most recent review, because what we actually need to do is create a common License definition and reference it from both license and Source.license (rather than repeating the title, description, type etc. in both places).

@odscrachel odscrachel force-pushed the 123-update-license-codelist branch from a046ec3 to d8e8fa3 Compare March 4, 2026 13:40
Comment thread schema/rdls_schema.json Outdated
@duncandewhurst duncandewhurst merged commit 27c6d2c into 1.0-dev Mar 5, 2026
5 checks passed
@duncandewhurst duncandewhurst deleted the 123-update-license-codelist branch March 5, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Add license field to the source object [Proposal] review license.csv codelist

2 participants