Repository navigation
relay: reach mdsip over a Unix socket (socket=), image listens on FDP_MDSIP_SOCKET - #20
Merged
Merged
Conversation
…socket Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…connection forms Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
host= and port= remain the default. port= is now strict: trailing text such as port=80abc, which std::atoi read as 80, is refused at load. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… tests the socket form Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e sandbox flag; mode=666 asserted Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…log quirk Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.exthandler ... socket=/pathmakes the relay connectAF_UNIX;host=/port=stay the default andsocket=with either is refused at load.port=is now strict (trailing text refused).fdp-mdsip-serverlistens onUNIX-LISTEN:$FDP_MDSIP_SOCKET,fork,unlink-early,mode=666when the variable is set; TCP otherwise. Build-time assertions cover both listener lines.\psirz240-775 ms against 17 ms on atlas). Design and measurements: d3d-origin-admindocs/specs/2026-10-13-mdsip-unix-socket-design.md; plandocs/plans/2026-10-13-mdsip-unix-socket.md.Test plan
ResolveMdsipTarget(defaults, TCP, Unix, both-forms refusal, port range and trailing text, path length);MdsipSessionsover a Unix socket; absent socket and over-long path fail naming the cause (22 cases)run_relay_e2e.shTCP andRELAY_SOCKET=/tmp/fdp-relay-e2e.sock: banner asserted per mode, all sections, new 6b large-reply check (medians ~27 ms), leak counter 1/1/1release-0.3.5; both images' labelsFollow-ups (not in this PR)
scripts/mdsip-sandbox.shhas no socket mode, so the harness exercises the relay'ssocket=path against the host stand-in, not the container'sFDP_MDSIP_SOCKETbranch; the harness refusesRELAY_SOCKETwithMDSIP_SANDBOXfor that reason. The production acceptance table in the design doc is the gate until the sandbox script learns the socket form.idle=,timeout=,maxsessions=are still parsed with uncheckedatoi/strtoul.🤖 Generated with Claude Code