Repository navigation
Make toksearch the only data source - #90
Open
AreWeDreaming wants to merge 37 commits into
Open
AreWeDreaming wants to merge 37 commits into
AreWeDreaming wants to merge 37 commits into
Conversation
- Also lower standard precision because the default was ridiculus before.
Collaborator
Author
|
I see that we are already inheriting a |
Collaborator
Author
|
The charge_exchange test fails because I cannot run the required The other tests should do better with the commit I'll push in a moment. |
Collaborator
Author
|
This is now in principle in reasonable shape to be merged but I would rather have all the dependencies:
Merged down and published first because I do not want all these submodules here for long. Now we could in principle keep the |
- Remove mappings in core_profiles
DIII-D MDSplus stores AEQDSK.SEPLIM, GAPIN, GAPOUT, GAPTOP, and GAPBOT in metres with units explicitly labelled in the tree. Remove the erroneous /100 from _compose_closest_wall_distance and _compose_gap_values. Drop the stale tolerance overrides in test_config for these fields. Follow-up to #113 (same issue confirmed for RSURF/ZSURF/AMINOR). Depends on gafusion/omas#443 before omas_validation tests will pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
I've confirmed that these are all stored in MDSplus in meters. In addition, the correction of the filters applied in OMAS exposed some weaknesses of the filters and test comparison in imas_composer. In particular, it is possible for the x-points and strike points to have missing interior values so simply using awkward arrays is not sufficient. The recommended solution appears to be using Nones for missing interior entries in the awkward arrays. This has been implemented and fixes the comparisons with OMAS. Also cleaning up some junk claude comments.
TRANSPORT.GLOBAL.TIMES.TAUE occasionally contains unphysical outliers (e.g., 154 s at t≈2.32 s near the L→H transition) that pass the existing tau_e > 0 guard but inflate rms(ref) by ~40x, making NRMS values artifactually close to 1. Adding the < 5.0 s upper bound removes these artifacts while retaining all physically meaningful confinement times for DIII-D H-mode shots (typical range 0.05–0.4 s). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Follows gafusion/omas#440, which made the ECE IDS homogeneous with ece.time taken from the TECE01 time base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er merged in Brings in the AEQDSK length-scale unit fixes and the He beam fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to 38b8139 mirroring gafusion/omas a006adc9 and 8a088272: SEPLIM, GAPIN/GAPOUT/GAPTOP/GAPBOT and the strike points RVS*/ZVS* are stored in metres and AREA in m^2, so drop the /100 and /10000 scalings. The strike point sentinel is -0.89 on the stored value. Drop the tolerance overrides that absorbed the 32-bit rounding of the conversion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and the fetch error fix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR make imas_composer only allow fetching via toksearch. It also adds the
toksearch_d3dandomassubmodule temporarily to handle the dependency on the two work in progress repos.This PR comes with CI that needs a
BEARER_TOKENsecret which is then used to load the DIII-D data in both imas_composer and omas via fdp.