Skip to content

Conversation

@godronus
Copy link
Contributor

@godronus godronus commented Nov 12, 2025

@qrdl - Please read the Rust example.. it is mostly MCP server assisted.. I read it and it looks ok. It certainly works, but may not be the best implementation

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds KV store usage examples for both Rust and JavaScript implementations, along with updates to dependency versions across the repository to use workspace-managed dependencies and newer SDK versions.

  • Adds new KV store example applications in Rust and JavaScript demonstrating usage of key-value storage APIs
  • Updates SDK dependencies to use workspace management in Rust projects (fastedge 0.3.1, proxy-wasm 0.2.4)
  • Updates JavaScript SDK to version 2.1.0 across all JavaScript projects
  • Updates AssemblyScript dependencies and fixes imports to use the new fastedge namespace

Reviewed Changes

Copilot reviewed 37 out of 45 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rust/http/kv-store/* New Rust KV store example with support for get, scan, zscan, zrange, and bfExists operations
javascript/src/kv-store/* New JavaScript KV store example with TypeScript implementation and query parameter validation
rust/Cargo.toml Adds workspace dependencies for fastedge and proxy-wasm
rust/*/Cargo.toml Updates to use workspace-managed dependencies
javascript/README.md Adds KV store link to documentation (contains incorrect path)
assemblyscript/* Updates dependencies and fixes imports for new SDK structure
github-actions/* Updates SDK versions to 2.1.0
Files not reviewed (5)
  • assemblyscript/package-lock.json: Language not supported
  • github-actions/multi-app-workflows/package-lock.json: Language not supported
  • github-actions/single-app-workflows/package-lock.json: Language not supported
  • javascript/src/mcp-server/package-lock.json: Language not supported
  • javascript/src/static-assets/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@godronus godronus requested a review from qrdl November 12, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants