Docling exposing backend arg and linting/publishing in CI
#1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
jabra,
maykcaldas,
mskarlin,
nadolskit and
whitead
dosubot
bot
added
the
size:M
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the backend parameter in the parse_pdf_to_pages function for the paper-qa-docling package and adds the package to CI linting and publishing workflows.
- Adds
backendparameter to allow customization of the PDF parsing backend - Includes paper-qa-docling in both test and build CI workflows
- Updates metadata to include backend information for better tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/paper-qa-docling/src/paperqa_docling/reader.py | Exposes backend parameter with proper type hints, passes it to PdfFormatOption, and includes it in metadata name |
| .github/workflows/tests.yml | Adds paper-qa-docling package build and inspection to the lint job |
| .github/workflows/build.yml | Adds paper-qa-docling package to the publish workflow for distribution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamesbraza
force-pushed
the
better-docling
branch
from
ae874e6 to
22302bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed these in #1121
Note
Expose a configurable Docling PDF backend in the reader and update CI to build, test, and publish the paper-qa-docling package.
packages/paper-qa-docling/src/paperqa_docling/reader.py):backendarg toparse_pdf_to_pages(default:DoclingParseV4DocumentBackend), pass through toPdfFormatOption.backendin outputParsedMetadata.name..github/workflows/build.yml): Build, download, and cleanpackages/paper-qa-doclingartifact alongside existing packages..github/workflows/tests.yml): Add build/check and cleanup steps forpaper-qa-doclingin Python 3.11 matrix.Written by Cursor Bugbot for commit b7031e1. Configure here.