Coil activation - #31
Merged
Merged
Conversation
kpentland
self-requested a review
August 26, 2025 14:15
kpentland
added
enhancement
kpentland
removed their request for review
August 26, 2025 14:16
kpentland
added
ready-for-final-tests
kpentland
added
ready-for-final-tests
Collaborator
|
Happy with these changes, seem to work on my end - will continue testing further. New docstrings added to nonlinear_solver.py - need to keep maintaining good docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added argument to dynamic stepper to make the resistances of the active coils time dependent.
This allows to activate/deactivate the active coils without modifying the machine geometry directly.
Chenges needed to a few core algos in nonlinear_solve, simplified_solve and linear_solve.
I've also removed the attribute .R for "resistance" in favour of .coil_resist as could be confused with radius (like for eq.R)
Tests and examples amended accordingly.
Tested on pytests and example5