Make supplied linearisation reuse deterministic - #112
Open
nicamo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92.
Motivation
Issue #92 identified that a bare cached
dIydIdoes not record the passive-mode basis used to build it. Coupling-based selection and post-Jacobian mode removal can change that basis, making reuse brittle or dimensionally inconsistent.Changes
dIydIonly withmode_selection="timescale".mode_removal=False.initialize_from_ICs(..., dIydI=...)calls.dIydIanddIydthetadimensions against the selected basis, grid, and profile parameterisation.Scope
This does not remove
mode_removal. Fresh coupling-based linearisations can continue to use it. Timescale selection continues to disable post-Jacobian mode removal automatically. The restriction applies specifically to externally supplied current-response Jacobians, whose column basis must be deterministic.Validation
freegsnke/tests/test_mode_selection.py: 6 passed.jtorafter a linear evolution step.