Prevent not sending a webhook on market update by requiring message to be added to input box#191
Open
StarkITA wants to merge 1 commit intoFuelRats:masterfrom
Open
Prevent not sending a webhook on market update by requiring message to be added to input box#191StarkITA wants to merge 1 commit intoFuelRats:masterfrom
StarkITA wants to merge 1 commit intoFuelRats:masterfrom
Conversation
StarkITA
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've made a very crude (and untested, I will add) edit to the market page, simply adding the required tag in the HTML, to prevent sending an update which would not trigger the sent of a webhook.
Ideally I should've gone and fixed the underlying issue, as this is just a bandaid, but I figured this is better than nothing, as I unfortunately am not confident in implementing that fix myself.
Thanks!