Fix recursion when opening regular files with C-j in dired-narrow - #237
Open
nicewise wants to merge 1 commit into
Open
Fix recursion when opening regular files with C-j in dired-narrow#237nicewise wants to merge 1 commit into
nicewise wants to merge 1 commit into
Conversation
Instead of unconditionally re-entering narrowing after `dired-narrow-find-file`, check whether the resulting buffer is still in `dired-mode`. This prevents unintended recursion when opening regular files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When pressing
C-jindired-narrow, the commanddired-narrow-enter-directoryinserts a magic string and exits theminibuffer. The control flow in
dired-narrow--internalthen callsdired-narrow-find-fileand unconditionally re-enters narrowing.This works correctly for directories, but when the target is a regular
file, narrowing may re-enter unexpectedly or produce inconsistent
behavior.
Cause
The current implementation does not distinguish between entering a
directory and opening a regular file after calling
dired-narrow-find-file. It always restarts the narrowing loop.Solution
After calling
dired-narrow-find-file, check whether the resultingbuffer is still derived from
dired-mode. If so, it means a directorywas entered and narrowing should restart. Otherwise, if a regular file
was opened, narrowing should not re-enter.
This keeps the original behavior for directories while avoiding
unnecessary recursion for regular files.
Result
C-jon directories: enter directory and continue narrowingC-jon regular files: open file and exit narrowing