Conversation
From their changelog: Fix to rename ub_callback_t to ub_callback_type, because POSIX reserves _t typedefs
Fruneau
requested changes
Mar 4, 2017
Owner
Fruneau
left a comment
Fruneau
left a comment
There was a problem hiding this comment.
Hi,
Thanks for the patch. I just have a single issue with compilation breakage with earlier versions of unbound.
| __attribute__((nonnull(1,3,4))) | ||
| bool dns_resolve(const char *hostname, dns_rrtype_t type, | ||
| ub_callback_t callback, void *data); | ||
| ub_callback_type callback, void *data); |
Owner
There was a problem hiding this comment.
You should provide a compatibility layer with the older versions of the lib in some way. For example:
#define UNBOUND_FULL_VERSION \
((UNBOUND_VERSION_MAJOR << 16) \
| (UNBOUND_VERSION_MINOR << 8) \
| (UNBOUND_VERSION_MICRO))
#if UNBOUND_FULL_VERSION < 0x010601
typedef ub_callback_t ub_callback_type;
#endif
jerith666
added a commit
to jerith666/nixpkgs
that referenced
this pull request
Mar 11, 2017
this is a stop-gap, applying the work-in-progress patch from Fruneau/pfixtools#21, while we await its acceptance upstream.
7 tasks
Owner
|
Hi @cpages, could you update the PR? |
Author
|
I'm sorry but I don't really have the time to fix and test this properly right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From their changelog: Fix to rename ub_callback_t to ub_callback_type, because POSIX reserves _t typedefs