Klippain compatibility with HH v2.5#517
Conversation
|
could you put this please in a draft state? Or can it be already integrated? |
|
need some tester before update HH... |
|
A pull request is not required to use/test a branch |
|
Instead of checking for mmu.enabled would it be possible via rename existing to set klippain mmu enabled to false/true if the related function in MMU is used? |
|
i changed the base to develop, hopefully to prevent the issues of last time |
Change EJECT to boolean for MMU_END
|
For me it seems to be ok... |
|
is it ready for review? |
|
with this version use with HHv2.5+ no need to have to add entries in printer.cfg |
|
I'll do a couple of minor changes to change some wording in the documentation and also add warning that <v2.5 is deprecated and will be removed in the future. This way we will be able to keep the code base more clean by removing in a next Klippain version all the checks about the HH version |
|
@Benoitone are the changes ok for you? |
|
@Frix-x I rework a little bit yours startup modifications. I think it's ok now... can you check? |
|
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
|
Whats the status? |
Working on my side… |
|
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
|
Hello @Benoitone , I'm coming back to the project and will work on merging this branch when you are ready :) |
try to make klippain compatible with Happy_Hare v2.5
Actually in developpment in happy_hare variables branch