fix: PHP warnings triggered by the test suite

[alquerci]

The test should fail when a warning PHP error occurred.

Depends on

• fix(test): exit code of lime test #301

How to execute tests?

To make test passes, I apply the following dependencies:

• Restore support of PHP <7.1 #293
• fix(test): docker images build to handle old linux distributions #270
• fix(test): exit code of lime test #301

Checkout the "bundle": https://github.com/alquerci/symfony1/tree/fixtest-fail-on-php-errors--dev

Then execute:

test/bin/test --dependency-preferences 'lowest highest'

What is done?

• Set consistent error_reporting to catch from PHP warnings and higher errors.
• [validator] Fix two kind of warning
• [mailer] fix the support for swiftmailler 6
  • An alternative with tests for swiftmailer fix Adapt to Swiftmailer 5 and Swiftmailer 6 version of class Swift_ConfigurableSpool #279
  • The default sfMailer transport for Switf v6 is Swift_SmtpTransport instead of Swift_MailTransport.
    • As Swift_MailTransport as been removed.
  • Use composer version of swiftmailler by default on test.
  • Add test without composer
  • Remove duplicated code for loading from submodule
• Update core autoloader, and apply 4 space indents.
  • data/bin/symfony symfony:test --trace --update-autoloader

What about the CI?

I try to put a PHP error_reporting directive, but the execution environment looks like different than docker.

Next steps

• notice
• strict
• deprecated

[alquerci]

@thePanz hey, I got it tests passes on GitHub action.

Let me know whether this PR has any chance to be merged.

[thirsch]

This approach is a bit like https://github.com/FriendsOfSymfony1/symfony1/pull/237/files but way more elegant.

Question is, if we are able to support swiftmailer 6 including the doctrine spools, do we really need to support swiftmailer 5?

[alquerci]

Good question, I guess not.

But it depends, on the ability of applications using swiftmailer 5 to migrate to swiftmailer 6.

[alquerci]

This opens a path to add support for symfony/mailer.

[thirsch]

I do like this approach to support the files being loaded by composer.

[thirsch]

@thePanz and @connorhu this will bring support for composer autoloading in the tests and a way towards getting rid of the submodules.