multi-server tests: profiling test packet rate adjustments - #5909
Open
marc-casavant wants to merge 1 commit into
Open
multi-server tests: profiling test packet rate adjustments#5909marc-casavant wants to merge 1 commit into
marc-casavant wants to merge 1 commit into
Conversation
…20s to ensure deterministic valgrind profiling
marc-casavant
force-pushed
the
dev-marc-casavant/profiling-test-adjustments
branch
from
July 24, 2026 18:19
3486b6a to
2bf8157
Compare
arr2036
force-pushed
the
master
branch
3 times, most recently
from
July 25, 2026 22:07
a5f29fd to
18a1035
Compare
marc-casavant
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's what changed (replaces PR #5907):
proto_load configuration adjusted to send packets at a slower rate which allows us to have more consistent profiling results when using Valgrind.
we attempted to increase the rate to 200pps to make the tests even quicker but that made things worse when profiling with Valgrind; tests like the mysql tests couldn't have all messages processed before the test ended. Even at 100pps which was the original rate caused issues with more complex tests like the mysql test.
50pps seems to be a sweet spot for running tests and profiling with Valgrind. Slower than our original short.ci test but gives us better results.