Add freeradius-prof.image as a conditional prerequisite to profiling test runs - #5863
Open
marc-casavant wants to merge 1 commit into
Open
Add freeradius-prof.image as a conditional prerequisite to profiling test runs#5863marc-casavant wants to merge 1 commit into
marc-casavant wants to merge 1 commit into
Conversation
… test targets when MODE=profiling
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
arr2036
force-pushed
the
master
branch
3 times, most recently
from
July 25, 2026 22:07
a5f29fd to
18a1035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
make test.multi-server.<suite>.<test> MODE=profilingdirectly would fail with a Docker pull error because thefreeradius4-profiling/ubuntu24:<sha>image didn't exist locally.The image build step (freeradius-prof.image) was only wired as a prerequisite on the top-level
test.multi-server.profilingandtest.multi-server.profiling.citargets, and not on individual test targets.The fix is to add
freeradius-prof.imageas a conditional prerequisite to each individual test target inside the TEST_MULTI_SERVER_INSTANCE macro.