Add support for directoryName subjectAltNames#5703
Open
Firstyear wants to merge 1 commit into
Open
Conversation
Firstyear
force-pushed
the
20260107-v3.2.x-dirname-san
branch
2 times, most recently
from
January 7, 2026 05:02
e539147 to
58f434c
Compare
This adds support to extract and provide directoryName's from the subjectAltName extension to modules.
Firstyear
force-pushed
the
20260107-v3.2.x-dirname-san
branch
from
January 7, 2026 05:03
58f434c to
3ad8cea
Compare
Author
|
Hi, it would be great to have this reviewed so that I can also contribute it to 4.x as well. |
arr2036
force-pushed
the
v3.2.x
branch
2 times, most recently
from
May 16, 2026 16:57
1817b50 to
fdf4d93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to extract and provide directoryName's from the subjectAltName extension to modules.
The primary question I have during review is the changes to
share/dictionary.freeradius.internal. There were no more ID's left in the 193x range, so I needed to use some from 1960. Is that valid and okay?