Refactor and optimize the ColonizationSaveGameReader class.#97
Open
teo-tsirpanis wants to merge 2 commits intoFreeCol:masterfrom
Open
Refactor and optimize the ColonizationSaveGameReader class.#97teo-tsirpanis wants to merge 2 commits intoFreeCol:masterfrom
teo-tsirpanis wants to merge 2 commits intoFreeCol:masterfrom
Conversation
Allocations and lines of code were reduced.
It eliminates a cyclic dependency design smell reported by Designite.
Member
|
Curious. ColonizationSaveGameReader is a rarely used standalone class. Refactoring it has very limited benefit. I have to ask why did you bother? |
Author
|
It is for a "Software Quality" university project. We had to pick a project and apply refactorings to it to increase its quality and my team chose FreeCol. And I personally enjoy refactoring and optimizing code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
ColonizationSaveGameReaderclass by using static methods instead of creating objects only to call one method on them namedprintorrun.Besides the reduced temporary object allocations, this PR also eliminated a redundant copy of the entire save file at the class' now-deleted constructor, and an array copy at the
getStringmethod by using another overload of Java'sStringclass' constructor.Speaking of
getString, it was moved to an inner class namedUtilitiesto avoid a cyclic dependency warning by Designite.