Skip to content

Conversation

@jlambatl
Copy link

@jlambatl jlambatl commented Sep 23, 2025

Hello,

This pull request bumps the version of simdjson from 3.12.3 to 4.0.7.

Due to some API changes with the introduction of 4.x, I've added handling and tests for ondemand::json_type::unknown. At this point, it returns an error. I tried to follow existing conventions within the codebase for how to handle the error.

The compiler was reporting that the following two lines were unused

  simdjson::padded_string json_string;
  ondemand::document doc;

I've removed them to stop the errors; however, I wanted to explicitly call this out because it may have other consequences that you are aware of. I am happy to return them if this change is a problem.

The files

  • src/simdjson.cpp
  • src/simdjson.h

Have been directly copied (unmodified) from the releases page singleheader.zip

@FourierTransformer
Copy link
Owner

It looks like it doesn't actually build with luarocks make. I think once that's resolved we can get this merged. Also 4.0.7 came out in the meanwhile.

@jlambatl
Copy link
Author

🤦 That it didn't compile, I am sure that I tested it before pushing up. Sorry for wasting your time.

I've bumped the upstream version to 4.0.7, too.

The code has been formatted. I'm not sure how you feel about that, but I'm happy to revert it as I realise that the format might not be for everyone as it's from an internal style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants