Updating simdjson to 4.0.6 #103
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request bumps the version of simdjson from 3.12.3 to 4.0.7.
Due to some API changes with the introduction of 4.x, I've added handling and tests for
ondemand::json_type::unknown. At this point, it returns an error. I tried to follow existing conventions within the codebase for how to handle the error.The compiler was reporting that the following two lines were unused
I've removed them to stop the errors; however, I wanted to explicitly call this out because it may have other consequences that you are aware of. I am happy to return them if this change is a problem.
The files
src/simdjson.cppsrc/simdjson.hHave been directly copied (unmodified) from the releases page
singleheader.zip