Add RN Owl and new size for featured badges - #67
Merged
Conversation
added 6 commits
June 23, 2022 11:53
these svg files have been compressed leaving classNames intact, also added role and aria-labelledby attributes
these svg files have been compressed leaving classNames intact, also added role and aria-labelledby attributes
add all additional props for featured badge
jpdriver
reviewed
Jun 23, 2022
jpdriver
self-requested a review
June 23, 2022 16:21
jpdriver
approved these changes
Jun 23, 2022
jpdriver
left a comment
jpdriver
left a comment
Contributor
There was a problem hiding this comment.
nice one, and love that you added the a11y stuff too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
inner-ring&outer-ring) for hover effectsrole="img"andaria-labelledby=[id]to each SVG with a corresponding <title id="[id]"> following accessibility guidelines outlined in this article: Creating Accessible SVGs by Carie Fisher This effort was picked up from PR36 <- this PR can be closed with this update. 💅