chore: update-nx #472
chore: update-nx #472
Conversation
|
WalkthroughConsolidates workspace catalog entries and replaces several explicit devDependency/version pins with pnpm catalog specifiers; bumps Nx-related packages to 22.x; adds a Vitest coverage include pattern; and replaces a Vitest test type import from Changes
Sequence Diagram(s)(Skipped — changes are configuration and version/catalog updates and a typing tweak; no control-flow or runtime feature additions to diagram.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 8e45f72
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
package.json(6 hunks)packages/journey-client/package.json(1 hunks)packages/journey-client/src/lib/device/device-profile.test.ts(2 hunks)pnpm-workspace.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Mend Code Security Check
- GitHub Check: pr
🔇 Additional comments (6)
pnpm-workspace.yaml (1)
27-31: LGTM! Catalog structure for Vitest packages looks good.The vitest catalog consolidates testing dependencies and will ensure consistent versions across the workspace.
packages/journey-client/package.json (1)
33-38: LGTM! Catalog specifiers are correctly applied.The migration to catalog-based dependency resolution ensures consistent versions across the workspace and aligns with the catalog definitions in
pnpm-workspace.yaml.packages/journey-client/src/lib/device/device-profile.test.ts (2)
89-89: Type annotation correctly updated.The
warnSpytype annotation is properly updated to match the import change.
10-10: SpyInstance → MockInstance migration is complete.Verification across all 69 test files in the codebase confirms zero remaining
SpyInstanceusages. The file mentioned in the review correctly importsMockInstancefrom vitest. The migration is complete.package.json (2)
81-82: LGTM! Catalog-based dependency resolution applied correctly.The migration to catalog specifiers for Vitest, Vite, and TypeScript dependencies ensures consistent versions across the workspace.
Also applies to: 99-99, 111-111, 114-116
58-67: Nx 22 compatibility verified — no breaking changes apply to this workspace.The workspace is already compatible with Nx 22.0.2. Verification confirms:
- All plugins in nx.json use v2 syntax (no CreateNodes V1 migration needed)
- No deprecated configurations detected (useLegacyTypescriptPlugin, NX_DISABLE_DB, simpleName, deleted webpack options)
- Release management uses Changesets (third-party tool), not Nx's built-in system affected by the legacy release removal
- tsconfig.base.json has no path mappings (nx format sorting change doesn't apply)
- Using pnpm (package manager --legacy-peer-deps rule only affects npm)
No additional configuration or migration steps required.
| vite: ^7.1.12 | ||
| typescript: ^5.9.3 |
There was a problem hiding this comment.
🧩 Analysis chain
Verify the Vite version is correct.
The version ^7.1.12 appears unusually high. Please confirm this is the intended version.
🌐 Web query:
What is the latest stable version of Vite?
💡 Result:
The latest stable Vite release is v7.1.4. [1][2]
Sources:
- npm package page for vite (shows v7.1.4). [1]
- Vite releases documentation (points to npm for latest stable). [2]
[1] https://www.npmjs.com/package/vite
[2] https://vite.dev/releases
Correct the Vite version constraint in pnpm-workspace.yaml.
The latest stable Vite release is v7.1.4, but the file specifies ^7.1.12, which references a version that does not exist in stable releases. This constraint will fail to resolve or pull a pre-release version. Update to ^7.1.4 or an appropriate stable version.
🤖 Prompt for AI Agents
In pnpm-workspace.yaml around lines 14 to 15, the Vite version constraint is
incorrect (currently ^7.1.12) and references a non-existent/stable-unstable
release; update the constraint to a valid stable release such as ^7.1.4 (or
another chosen stable version) so dependency resolution succeeds, ensuring the
line for vite is replaced with the corrected version string.
There was a problem hiding this comment.
this version is correct, vite is on 7.1.12
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Vite 7.1.12 version release
💡 Result:
Vite v7.1.12 was released on October 23, 2025 (tag v7.1.12). [1][2]
Sources:
- GitHub releases (vitejs/vite) — v7.1.12 (Oct 23, 2025). [1]
- Package listing / metadata (vite v7.1.12). [2]
@ryanbas21, you're absolutely right! I apologize for the incorrect flag. Vite v7.1.12 was indeed released on October 23, 2025, and is a valid version. The version constraint ^7.1.12 in the catalog is correct.
Thank you for the correction!
✏️ Learnings added
Learnt from: ryanbas21
Repo: ForgeRock/ping-javascript-sdk PR: 472
File: pnpm-workspace.yaml:14-15
Timestamp: 2025-11-03T19:07:15.245Z
Learning: Vite version 7.1.12 is a valid release that was published on October 23, 2025.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
The failure was classified as 'environment_state' rather than 'code_change' for the following reasons:
No Changes to Failing Test File:
The PR diff shows no modifications to the failing test file (e2e/davinci-suites/src/phone-number-field.test.ts). The tests that are failing were not touched by this PR.
No Application Logic Changes:
The PR contains only dependency version upgrades (Nx v21 to v22, Vitest v3 to v4, Vite v6 to v7) and formatting changes. There are no changes to application code, UI components, or business logic that would affect the device registration flow being tested.
External Service Dependency Failure:
Both failing tests timeout while waiting for a 'Registration Complete' heading to appear after submitting user registration information. This indicates the backend authentication/registration service is not responding or completing the registration flow. The tests are making real API calls to external services that manage user registration and authentication.
Cleanup Hook Also Fails:
The afterEach cleanup hook also times out trying to delete the test user via the 'USER_DELETE' button. This further confirms the external service is not responding properly, as both creating and deleting users fail.
Timing-Based Failures:
The errors are all timeout-based ("Test timeout of 30000ms exceeded", "Timeout: 5000ms"), which is characteristic of external service unavailability rather than code defects. If the code changes introduced a bug, we would expect different error types (syntax errors, type errors, assertion failures on wrong values).
No Logical Connection to Changes:
Upgrading Nx tooling and test framework versions does not affect whether external authentication APIs respond to HTTP requests. The only code change in a test file was changing SpyInstance to MockInstance in a completely different test file (device-profile.test.ts), which is unrelated to these e2e tests.
The failures indicate an environmental issue where the external authentication/user management service required by these e2e tests is not available or not responding during test execution.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
@forgerock/davinci-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed 83564da to https://ForgeRock.github.io/ping-javascript-sdk/pr-472/83564da00c13e295a587820f05ae796e2a0a3014 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-82.0 KB, -100.0%) 📊 Minor Changes📉 @forgerock/journey-client - 82.0 KB (-0.0 KB) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
JIRA Ticket
N/A
Description
Updates Nx, adds catalog support, updated deps to use catalogs where appropriate. Fixed failing test from vite upgrade.
Summary by CodeRabbit
Chores
Tests