Release PR #345
Release PR #345
Conversation
|
View your CI Pipeline Execution ↗ for commit 972c198
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (18.52%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 18.52% 18.52% -0.01%
==========================================
Files 138 138
Lines 27402 27401 -1
Branches 963 963
==========================================
- Hits 5076 5075 -1
Misses 22326 22326 🚀 New features to boost your workflow:
|
|
Deployed 3c04650 to https://ForgeRock.github.io/ping-javascript-sdk/pr-345/3c04650d5bc21b010058ce24191d61c0f1602366 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-82.0 KB, -100.0%) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
changeset-release/main
branch
7 times, most recently
from
7f85e3d to
84aa034
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
6 times, most recently
from
d5812af to
997d98a
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
4 times, most recently
from
5eb620d to
954ce37
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
5 times, most recently
from
a5a72fb to
fae494a
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
1fceeb2 to
022b06c
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
022b06c to
625b514
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/sdk-effects/storage/CHANGELOG.md (1)
1-32: Context: Prioritize test coverage improvements for future releases.The PR objectives note that project test coverage is at 19.05%, below the 40% target. While this release focuses on features and dependency updates, consider prioritizing test coverage in the next iteration to strengthen the codebase before additional releases.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (44)
.changeset/breezy-actors-sell.md(0 hunks).changeset/bright-lights-yawn.md(0 hunks).changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/good-games-accept.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/kind-guests-sneeze.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/orange-peaches-warn.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/slow-teeth-melt.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/tender-schools-scream.md(0 hunks).changeset/thin-nights-send.md(0 hunks).changeset/tired-melons-wish.md(0 hunks).changeset/wild-items-stop.md(0 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/journey-client/CHANGELOG.md(1 hunks)packages/journey-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (22)
- .changeset/chubby-chairs-dream.md
- .changeset/dirty-queens-design.md
- .changeset/calm-waves-change.md
- .changeset/dull-rockets-give.md
- .changeset/every-bottles-sleep.md
- .changeset/small-rats-cut.md
- .changeset/wild-items-stop.md
- .changeset/slow-teeth-melt.md
- .changeset/moody-chefs-hammer.md
- .changeset/kind-guests-sneeze.md
- .changeset/thin-nights-send.md
- .changeset/breezy-actors-sell.md
- .changeset/good-games-accept.md
- .changeset/fine-windows-search.md
- .changeset/tender-schools-scream.md
- .changeset/bright-lights-yawn.md
- .changeset/shiny-crabs-wish.md
- .changeset/public-cougars-sneeze.md
- .changeset/orange-peaches-warn.md
- .changeset/spotty-tires-admire.md
- .changeset/icy-olives-make.md
- .changeset/tired-melons-wish.md
✅ Files skipped from review due to trivial changes (3)
- packages/journey-client/CHANGELOG.md
- packages/sdk-types/package.json
- packages/sdk-effects/sdk-request-middleware/package.json
🚧 Files skipped from review as they are similar to previous changes (15)
- packages/journey-client/package.json
- packages/sdk-types/CHANGELOG.md
- packages/protect/CHANGELOG.md
- packages/protect/package.json
- packages/sdk-effects/oidc/package.json
- packages/sdk-effects/oidc/CHANGELOG.md
- packages/oidc-client/package.json
- packages/sdk-effects/logger/CHANGELOG.md
- packages/oidc-client/CHANGELOG.md
- packages/sdk-effects/iframe-manager/CHANGELOG.md
- packages/sdk-effects/sdk-request-middleware/CHANGELOG.md
- packages/davinci-client/CHANGELOG.md
- packages/sdk-effects/iframe-manager/package.json
- packages/davinci-client/package.json
- packages/sdk-effects/logger/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (4)
packages/sdk-utilities/CHANGELOG.md (1)
3-9: Changelog entry is properly formatted and complete.The 1.3.0 release entry is correctly formatted with appropriate metadata (PR reference, commit hash, contributor attribution) and a clear description of the changes. The description effectively communicates the optimization (inlining constants) and its benefits (tree-shaking and type narrowing).
packages/sdk-utilities/package.json (1)
3-3: Version bump aligns with coordinated 1.3.0 release.Clean, minimal change with no modifications to exports, dependencies, or configuration. Part of the broader coordinated monorepo release.
packages/sdk-effects/storage/package.json (1)
3-3: Version bump with correct monorepo dependency resolution.Version bump to 1.3.0 is consistent with the storage CHANGELOG (line 21) which documents @forgerock/[email protected] as an updated dependency. The
workspace:*pattern on line 29 correctly resolves to workspace versions.packages/sdk-effects/storage/CHANGELOG.md (1)
3-21: Changelog properly documents 1.3.0 release with PR and commit attribution.Well-structured changelog entry following conventional format with:
- Three minor changes referencing PRs #412 (ESLint/type-only imports), #348 (token exchange), and #417 (return type standardization)
- One patch change for OIDC logout/user info (#363)
- Dependency update for @forgerock/[email protected] properly documented
- All contributors and commit hashes linked
Entries align with features mentioned in the PR objectives.
ryanbas21
force-pushed
the
changeset-release/main
branch
from
9d4668e to
53d9093
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
9 times, most recently
from
807f1bc to
28207cd
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
packages/sdk-effects/oidc/CHANGELOG.md (1)
14-14: Fix the stray hyphen in the changelog entry (duplicate of past review).Line 14 displays "- - Adds tests for OIDC effects package" with an extra leading hyphen. A previous review already flagged this issue; it remains unresolved.
Remove the extra hyphen so the bullet renders as a single list item.
-- [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - - Adds tests for OIDC effects package +- [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - Adds tests for OIDC effects packagepackages/oidc-client/CHANGELOG.md (1)
22-23: Fix the stray hyphen in the changelog entry (duplicate of past review).Lines 22–23 display "- - Standardizes return types on storage client and updates tests" with an extra leading hyphen. A previous review already flagged this issue; it remains unresolved.
Remove the extra hyphen so the bullet renders as a single list item.
-- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests +- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (44)
.changeset/breezy-actors-sell.md(0 hunks).changeset/bright-lights-yawn.md(0 hunks).changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/good-games-accept.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/kind-guests-sneeze.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/orange-peaches-warn.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/slow-teeth-melt.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/tender-schools-scream.md(0 hunks).changeset/thin-nights-send.md(0 hunks).changeset/tired-melons-wish.md(0 hunks).changeset/wild-items-stop.md(0 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/journey-client/CHANGELOG.md(1 hunks)packages/journey-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (22)
- .changeset/small-rats-cut.md
- .changeset/fine-windows-search.md
- .changeset/dull-rockets-give.md
- .changeset/wild-items-stop.md
- .changeset/bright-lights-yawn.md
- .changeset/public-cougars-sneeze.md
- .changeset/moody-chefs-hammer.md
- .changeset/kind-guests-sneeze.md
- .changeset/shiny-crabs-wish.md
- .changeset/calm-waves-change.md
- .changeset/tender-schools-scream.md
- .changeset/spotty-tires-admire.md
- .changeset/icy-olives-make.md
- .changeset/dirty-queens-design.md
- .changeset/slow-teeth-melt.md
- .changeset/every-bottles-sleep.md
- .changeset/good-games-accept.md
- .changeset/breezy-actors-sell.md
- .changeset/tired-melons-wish.md
- .changeset/chubby-chairs-dream.md
- .changeset/orange-peaches-warn.md
- .changeset/thin-nights-send.md
✅ Files skipped from review due to trivial changes (2)
- packages/sdk-effects/logger/package.json
- packages/davinci-client/package.json
🚧 Files skipped from review as they are similar to previous changes (15)
- packages/sdk-effects/oidc/package.json
- packages/sdk-utilities/package.json
- packages/sdk-effects/storage/package.json
- packages/protect/CHANGELOG.md
- packages/journey-client/package.json
- packages/sdk-effects/iframe-manager/package.json
- packages/sdk-types/CHANGELOG.md
- packages/sdk-types/package.json
- packages/sdk-effects/iframe-manager/CHANGELOG.md
- packages/oidc-client/package.json
- packages/journey-client/CHANGELOG.md
- packages/sdk-effects/sdk-request-middleware/package.json
- packages/davinci-client/CHANGELOG.md
- packages/sdk-utilities/CHANGELOG.md
- packages/sdk-effects/logger/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (1)
packages/protect/package.json (1)
3-3: Version bump aligns with release PR objectives.The version bump to 1.3.0 is consistent with the Changesets release automation and the PR's goal to release the newly implemented Ping Protect package.
|
|
||
| - [#348](https://github.com/ForgeRock/ping-javascript-sdk/pull/348) [`beb349a`](https://github.com/ForgeRock/ping-javascript-sdk/commit/beb349a9a13e7bb8fbad35bf9bda9e340545cffa) Thanks [@cerebrl](https://github.com/cerebrl)! - Implemented token exchange within OIDC Client | ||
|
|
||
| - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests |
There was a problem hiding this comment.
Fix the stray hyphen in the changelog entry.
Line 13 displays "- - Standardizes return types on storage client and updates tests" with an extra leading hyphen, creating a double-bullet rendering issue. This same formatting defect appears in the corresponding entry in oidc-client/CHANGELOG.md.
Remove the extra hyphen so the bullet renders cleanly.
-- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests
+- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests | |
| - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests |
🤖 Prompt for AI Agents
In packages/sdk-effects/storage/CHANGELOG.md around line 13, the changelog entry
contains a stray extra hyphen ("- - Standardizes...") causing a double-bullet;
remove the leading extra hyphen so the line reads a single hyphen followed by
the text ("- Standardizes return types on storage client and updates tests");
also apply the same correction to the matching entry in oidc-client/CHANGELOG.md
to keep both changelogs consistent.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
1de5458 to
fb05d62
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
2 times, most recently
from
e5eecb7 to
09f443e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
from
09f443e to
1b7cb55
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
packages/oidc-client/CHANGELOG.md (1)
22-23: Fix the stray hyphen in the changelog entry.Line 22 has a double hyphen ("- - Standardizes") that will render with an extra bullet in published notes. Remove the extra hyphen so it renders as a single bullet.
- [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests + [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - Standardizes return types on storage client and updates tests
🧹 Nitpick comments (1)
packages/protect/CHANGELOG.md (1)
7-7: Fix capitalization of "Ping Protect" in changelog entry description.The product name should be consistently capitalized as "Ping Protect" to match the PR objectives and other package changelogs in this release.
Apply this diff to fix the capitalization:
-- Implemented ping protect package +- Implemented Ping Protect package
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (49)
.changeset/breezy-actors-sell.md(0 hunks).changeset/bright-lights-yawn.md(0 hunks).changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/good-games-accept.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/kind-guests-sneeze.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/orange-peaches-warn.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/slow-teeth-melt.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/tender-schools-scream.md(0 hunks).changeset/thin-nights-send.md(0 hunks).changeset/tired-melons-wish.md(0 hunks).changeset/vast-dogs-make.md(0 hunks).changeset/wild-items-stop.md(0 hunks)e2e/journey-app/CHANGELOG.md(1 hunks)e2e/journey-app/package.json(1 hunks)e2e/journey-suites/CHANGELOG.md(1 hunks)e2e/journey-suites/package.json(1 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/journey-client/CHANGELOG.md(1 hunks)packages/journey-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (23)
- .changeset/spotty-tires-admire.md
- .changeset/dull-rockets-give.md
- .changeset/moody-chefs-hammer.md
- .changeset/slow-teeth-melt.md
- .changeset/vast-dogs-make.md
- .changeset/calm-waves-change.md
- .changeset/tender-schools-scream.md
- .changeset/kind-guests-sneeze.md
- .changeset/tired-melons-wish.md
- .changeset/small-rats-cut.md
- .changeset/icy-olives-make.md
- .changeset/wild-items-stop.md
- .changeset/orange-peaches-warn.md
- .changeset/dirty-queens-design.md
- .changeset/shiny-crabs-wish.md
- .changeset/good-games-accept.md
- .changeset/every-bottles-sleep.md
- .changeset/bright-lights-yawn.md
- .changeset/fine-windows-search.md
- .changeset/thin-nights-send.md
- .changeset/breezy-actors-sell.md
- .changeset/public-cougars-sneeze.md
- .changeset/chubby-chairs-dream.md
✅ Files skipped from review due to trivial changes (2)
- packages/sdk-effects/sdk-request-middleware/CHANGELOG.md
- e2e/journey-suites/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (17)
- packages/oidc-client/package.json
- packages/sdk-types/package.json
- packages/sdk-effects/iframe-manager/package.json
- packages/journey-client/CHANGELOG.md
- packages/sdk-utilities/CHANGELOG.md
- packages/journey-client/package.json
- packages/davinci-client/package.json
- packages/sdk-types/CHANGELOG.md
- packages/sdk-effects/logger/CHANGELOG.md
- packages/sdk-effects/logger/package.json
- packages/sdk-effects/oidc/CHANGELOG.md
- packages/protect/package.json
- packages/sdk-effects/iframe-manager/CHANGELOG.md
- e2e/journey-app/CHANGELOG.md
- packages/sdk-effects/storage/CHANGELOG.md
- packages/davinci-client/CHANGELOG.md
- e2e/journey-suites/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (6)
packages/oidc-client/CHANGELOG.md (1)
3-40: Changelog structure and consistency look good.The 1.3.0 release section is well-structured with appropriate categorization of changes into Minor and Patch sections, proper linking to PRs and commits, and accurate attribution. Dependency updates are correctly versioned to 1.3.0 across all related packages.
e2e/journey-app/package.json (1)
3-3: Version alignment is consistent with the release.The version bump to 1.3.0 aligns with the broader package versioning in this release PR. Since all workspace dependencies reference
workspace:*, they will correctly resolve to the new versions.packages/sdk-effects/storage/package.json (1)
3-3: Version bump to 1.3.0 looks good.The version bump is appropriate for this coordinated minor release, and workspace dependencies remain correctly configured for Changesets-managed publishing.
packages/sdk-effects/oidc/package.json (1)
3-3: Version bump to 1.3.0 is consistent with the coordinated release.Workspace dependencies (@forgerock/sdk-types, @forgerock/sdk-utilities) remain properly configured for Changesets publishing.
packages/sdk-utilities/package.json (1)
3-3: Version bump to 1.3.0 approved.The public API surface (exports for constants, types, and default entry point) remains unchanged. The version bump is appropriate for this minor release.
packages/sdk-effects/sdk-request-middleware/package.json (1)
3-3: Version bump to 1.3.0 is appropriate.The cataloged dependency (@reduxjs/toolkit) is correctly preserved without modification. This aligns with the coordinated 1.3.0 release across the SDK packages.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanbas21
force-pushed
the
changeset-release/main
branch
4 times, most recently
from
741f035 to
5c5e9d0
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
5c5e9d0 to
972c198
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#340
0fa522aThanks @ancheetah! - Implemented Ping Protect collector#396
036f495Thanks @ancheetah! - Added support for pre-filled phone number and country code#428
b327c79Thanks @ancheetah! - Added WebAuthn/FIDO2 collectorsPatch Changes
#413
9213bb9Thanks @ancheetah! - ExposesrequiredandvalidatePhoneNumberproperties on collectors#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error typeUpdated dependencies [
b0f4368,beb349a,dc4d4bd,7ffa428,6c06e70,93595d2,b0f4368,ef4ab6f,b0f4368]:@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#376
c48d9c8Thanks @ancheetah! - Implement tokenrevokemethod#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#402
bdbbbd2Thanks @cerebrl! - Implement force renew and revoke tokens that are replaced to tokens.get method#368
5fe1f95Thanks @ancheetah! - Added tests for oidc client#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error type#417
93595d2Thanks @ancheetah! - - Standardizes return types on storage client and updates tests#378
4d0ee71Thanks @cerebrl! - Migrate /authorize to RTK Query and improve result types#369
7cb0519Thanks @cerebrl! - Implement tokengetmethod for local tokens and autorenewPatch Changes
#471
ef4ab6fThanks @ancheetah! - Append query params to authorization url when providedUpdated dependencies [
b0f4368,beb349a,dc4d4bd,b0f4368,7ffa428,6c06e70,93595d2,b0f4368,ef4ab6f,b0f4368]:@forgerock/[email protected]
Minor Changes
18677d9Thanks @ancheetah! - Implemented ping protect package@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#412
b0f4368Thanks @ryanbas21! - feat: Update iframe-managerverbatimModuleSyntaxby correcting type-only imports and module exports.@forgerock/[email protected]
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK loggerverbatimModuleSyntaxby correcting type-only imports and module exports.@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#416
7ffa428Thanks @ancheetah! - - Adds tests for OIDC effects packagegetStorageKeyutilityPatch Changes
#471
ef4ab6fThanks @ancheetah! - Append query params to authorization url when providedUpdated dependencies [
b0f4368,6c06e70,b0f4368]:@forgerock/[email protected]
Minor Changes
#412
b0f4368Thanks @ryanbas21! - feat: Update storage packageverbatimModuleSyntaxby correcting type-only imports and module exports.#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#417
93595d2Thanks @ancheetah! - - Standardizes return types on storage client and updates testsPatch Changes
#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error typeUpdated dependencies [
6c06e70,b0f4368]:@forgerock/[email protected]
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK typesverbatimModuleSyntaxby correcting type-only imports and module exports.Patch Changes
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error type@forgerock/[email protected]
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK utilitiesREQUESTED_WITHandX_REQUESTED_PLATFORMconstants with literal types for better tree-shaking and type narrowing.@forgerock/[email protected]
@forgerock/[email protected]
Minor Changes
#412
b0f4368Thanks @ryanbas21! - feat: Implement new journey clientjourney()factory function for creating stateful client instances.resumelogic to correctly persist and retrieve plainSteppayloads, resolving prototype loss issues during serialization.#412
b0f4368Thanks @ryanbas21! - feat(journey-client): Add WebAuthn, QR Code, and Recovery Code supportFRWebAuthn,FRQRCode,FRRecoveryCodes) to handle advanced authentication methods within authentication journeys.TextOutputCallbackwas being incorrectly inferred asTextInputCallback.Patch Changes
b0f4368,b0f4368,beb349a,6c06e70,93595d2,b0f4368,b0f4368]:@forgerock/[email protected]
Patch Changes
beb349a,c48d9c8,dc4d4bd,bdbbbd2,b0f4368,5fe1f95,b0f4368,6c06e70,93595d2,4d0ee71,7cb0519,ef4ab6f,b0f4368]:@forgerock/[email protected]
Summary by CodeRabbit
New Features
Chores