Add support for swipe-to-change-song on preview sheet#771
Open
imjyotiraditya wants to merge 1 commit intoFoedusProgramme:betafrom
Open
Add support for swipe-to-change-song on preview sheet#771imjyotiraditya wants to merge 1 commit intoFoedusProgramme:betafrom
imjyotiraditya wants to merge 1 commit intoFoedusProgramme:betafrom
Conversation
Member
|
weird, it seems to cause servere lags for me in a debug build (1.5k item playlist). with how many songs did you test it? sadly, profiler isn't working so I can't figure out why that happens at the moment. |
Member
For some godforsaken reason my phone spends over 30s due to string comparisions. I've tested on another phone with almost the same songs (copied over 2k songs and only 100 songs difference) and I can't reproduce there, which makes the whole thing even weirder. Do you have any idea why that might possibly be?
|
Member
|
oh also,
any chance you can fix it? sorry for the long delay and thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.