Conversation
|
Preview affected pages: |
✅ Deploy Preview for flowfuse-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cc1cd71 to
5ed8e82
Compare
|
Rebased on One comment correction: the page comment claimed the 11ty layout rendered an empty second |
5ed8e82 to
e5bfaac
Compare
|
Rebased onto |
e5bfaac to
41e0df9
Compare
|
Rebased onto |
|
@dimitrieh the pictograms are the wrong size, they're too big. Compare the preview against the live version and you'll see the difference. Also, the email icon under each team member's picture should be filled and it has a weird spacing right now. |
| // Top-level routes still on 11ty, not yet ported to Nuxt (everything not listed above | ||
| // already falls through to the 11ty proxy by default). Remove entries here as they migrate: | ||
| // /about, /blueprints, /careers, /community, /events | ||
| // /blueprints, /careers, /community, /events |
There was a problem hiding this comment.
@dimitrieh /about needs to be added to the NUXT_ROUTES, otherwise, it won't load on local dev
There was a problem hiding this comment.
Added /about to NUXT_ROUTES. It had only been dropped from the informational list in the comment block below, which the middleware does not read.
| improve their processes continuously. | ||
| </p> | ||
| <p> | ||
| <NuxtLink to="/platform/security/#certifications" class="text-indigo-600 hover:text-indigo-800 font-medium">See our security certifications</NuxtLink> |
There was a problem hiding this comment.
Fixed. It was a <NuxtLink>, so the click was resolved client-side by vue-router, matched pages/[...slug].vue, found no content entry and 404'd. /platform/security/ is still 11ty, so it needs a plain <a href>.
| twitterSite: '@FlowFuseinc', | ||
| }) | ||
|
|
||
| useSchemaOrg([ |
There was a problem hiding this comment.
@dimitrieh app.vue already declares a sitewide defineOrganization(). Some fields here overlap with it so the rendered JSON-LD on /about/ ends up with duplicate entries. Worth trimming this block to just the fields app.vue doesn't already have.
There was a problem hiding this comment.
Trimmed to the fields app.vue does not carry: legalName, description, foundingDate, founder, address.
One correction on the mechanism: it resolved to a single #identity node, not duplicate entries, because both calls dedupe on the same @id. The duplication was inside it. url was overwritten with the www host, and sameAs concatenated into a list holding GitHub twice and LinkedIn and Twitter in two spellings each. The logo block also declared 396x215 for a file that is 529x287, so that goes too.
Facebook and YouTube were only in the page list, so they move to app.vue rather than being dropped.
The team grid reads useTeam(), the same src/_data/team files the blog byline
already resolves through; TeamMember gains the `order`, `facts` and `blog`
fields this page uses so it is typed rather than cast. The social glyphs reuse
the existing Icons{Github,Linkedin,Twitter}Icon components.
values.njk and benefits.njk each had exactly one caller - this page - so they
are two const grids here rather than components.
The frontmatter's `meta.organization` block was rendered by jsonld.njk as a
hand-built JSON string; it goes through useSchemaOrg, which escapes properly.
Production also renders a second, empty <h1> from layouts/page.njk's `nohero`
branch, because the page sets no `title`. Only the real heading survives.
Verified against production, with no structural differences.
…th <a> /about was only dropped from the informational "still on 11ty" list in legacy.ts, never added to NUXT_ROUTES, so the dev middleware kept proxying it to 11ty, which no longer has the page now that src/about.njk is gone. The security certifications link was a <NuxtLink>, so clicking it was resolved client-side by vue-router, matched pages/[...slug].vue, found no content entry and threw a 404 instead of loading 11ty's /platform/security/. The prerender link check passes either way, because it only sees the rendered href, and that target does exist in the merged build.
e70efbe to
3320717
Compare
The pictograms carried `w-full h-auto`. Tailwind v4 puts utilities in a layer
that resolves after `components`, where style.page.css lives, so `w-full` beat
`.company-value img { width: 128px }` and `.about-values .company-value img
{ width: 60px }` despite being less specific. Benefits rendered at 299px
instead of 128px, and values at 121-171px, each tracking its own PNG's aspect
ratio, instead of a uniform 60px. The 11ty markup carried no classes at all,
so dropping them restores both sizes.
Mail and RSS were <UIcon>, which renders a masked <span> with no intrinsic
aspect ratio: the mail link laid out 36px wide where the sibling glyphs get
20px, and Lucide's mail is an outline where the partial was solid. Both now
have components alongside the other social icons, carrying the same paths the
partials had.
Organization schema on the page repeated name, url, logo and sameAs, which
app.vue already declares. It resolved to one #identity node rather than two,
but the repeat overwrote url with the www host and concatenated sameAs into a
list holding GitHub twice and LinkedIn and Twitter in two spellings each. The
page now adds only what app.vue lacks; the two profiles it alone carried move
to app.vue so they stay sitewide.
|
Both fixed. Pictograms. They carried Email icon. It was a |
Yndira-E
left a comment
Yndira-E
left a comment
There was a problem hiding this comment.
I’m approving this. There’s only one small issue, which is also present in the live version: when one card is taller than the others, the other cards don’t adjust, and on hover, the hidden card slides behind the empty space at the bottom.
If you could fix it here, that would be great. Otherwise, we can address it in a follow-up PR. This isn’t a blocker, so I’ll leave it up to you.
2 participants
Description
Moves
/about/to Nuxt: the team grid, values, benefits and investors.The team grid reads the
team/data directory only. The merged lookup used for blog bylines also includesguests/, and three guest files are former team members still carrying theorderthey had as staff, so reading the merged one puts them back on the page.Related Issue(s)
Part of #5777
Checklist