icons: shared glyph set (layers / chevron / folder) + warm sidebar tints#2579
Open
100mountains wants to merge 2 commits into
Open
icons: shared glyph set (layers / chevron / folder) + warm sidebar tints#2579100mountains wants to merge 2 commits into
100mountains wants to merge 2 commits into
Conversation
The bottom-cluster SVGs are context-fill and .panel-sidebar-panel already fills currentColor, so colour alone recolours them: golden yellow for add-ons, red clay for passwords, pale warm grey for preferences. Purely cosmetic; three declarations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds workspaces/toolbar/icons.ts: the shared inline-SVG glyph set (svgUri helper; stacked-layers, chevron, neutral folder). context-stroke follows UI text colour via -moz-context-properties, so the glyphs sit in any theme without recolouring. The layers glyph is the same one the tab-stacks presentation (Floorp-Projects#2574) embeds for its chips, and the set backs the Vivaldi-style workspaces chooser offered in Floorp-Projects#2569 - landing it here keeps every later piece pointing at one copy. Completes the sidebar tint set with terracotta (reopen) and dusty rose (account); those two ids arrive with the offered workspaces/sidebar UX work and are inert until then. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the final derp-fork contribution batch (#2569). Two halves:
Shared glyph module —
workspaces/toolbar/icons.ts: ansvgUrihelper plus the inline-SVG set (stacked-layers, chevron, neutral folder).context-strokefollows UI text colour via-moz-context-properties, so the glyphs sit in any theme without recolouring. The layers glyph is the same one the tab-stacks PR (feat(tab-stacks): opt-in Vivaldi-style stacked presentation for native tab groups #2574) embeds for its chips, and the set backs the Vivaldi-style workspaces chooser offered in Final contribution batch from the derp fork — self-contained features offered upstream #2569 — landing it means every later piece points at one copy instead of re-embedding.Sidebar tints — the full warm, muted set for the bottom cluster: golden yellow (add-ons), red clay (passwords), pale warm grey (preferences), terracotta (reopen), dusty rose (account). The SVGs are context-fill and
.panel-sidebar-panelalready fillscurrentColor, so colour alone does it. The last two ids ship with the offered workspaces/sidebar UX work and are inert until then — included so the set lands complete.🤖 Generated with Claude Code