feat(shortcuts): chord-drag window move, a zen-mode key, and a don't-fire-while-typing guard#2575
Open
100mountains wants to merge 1 commit into
Open
Conversation
… guard Three related pieces on one chord family (Cmd+Alt on macOS, Ctrl+Alt elsewhere - meta on Windows is the Windows key, which nobody wants in a chord): - window-drag (new self-contained feature dir): hold the chord and drag anywhere - toolbars, tab strip, or web content - to move the window. Most useful in zen mode and multirow tabs, where the draggable titlebar is hidden or crowded. Bare-Cmd drags are deliberately not used: Cmd+click opens links/toggles multiselection, and web apps use Cmd+drag for canvas panning. - A default shortcut: chord+Z toggles zen mode via the existing floorp-toggle-zen-mode action. Saved configs are merged over defaults so the new entry reaches existing profiles. - Typing guard in the shortcut controller: bare printable single-key shortcuts (like a plain "Z") no longer fire while the user is typing - input/textarea/contenteditable, the shadow-DOM urlbar/searchbar/ findbar hosts, and remote content via browser.isInputFocused. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the final derp-fork contribution batch (#2569). Three related pieces on one chord family — Cmd+Alt on macOS, Ctrl+Alt everywhere else (meta on Windows is the Windows key, which nobody wants in a chord):
floorp-toggle-zen-modeaction. Saved configs are merged over defaults so the new entry reaches existing profiles (caveat noted in-code: a default the user deleted comes back until configs carry a schema version — deleted-vs-rebound isn't distinguishable today).browser.isInputFocused. Chorded shortcuts are unaffected.Validation honesty: daily-driven in derp on macOS (FF152 runtime); the guard's remote-content branch matches how derp shipped it. Not exercised on Windows/Linux beyond the chord choice logic.
🤖 Generated with Claude Code