Skip to content

Документация по оптимизации запросов на обновление с помощью UpdateViews #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
turbcool wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Документация по оптимизации запросов на обновление с помощью UpdateViews #208

turbcool wants to merge 4 commits into from

Conversation

@turbcool
Copy link
Contributor

@turbcool turbcool commented Jan 25, 2024 •
edited
Loading

Документация по оптимизации запросов на обновление с помощью UpdateViews

Anisimova2020
Anisimova2020 reviewed Jan 30, 2024
View reviewed changes
pages/products/flexberry-orm/odata-service/fo_update-view.ru.md Outdated
Атрибуты, мастера, детейлы, которые не включены в `UpdateView`, нельзя будет использовать в запросах на обновление объекта через OData. Кроме того, эти атрибуты, мастера и детейлы не будут загружены в бизнес-сервере. Несмотря на эти особенности, данная функция может дать прирост к производительности, особенно в случаях, когда объекты содержат множество детейлов.

### Использование
Изменить `UpdateView` для объекта можно на уровне приложения в файле `Startup.cs`, в методе `Configure`. Необходимо передать представления в параметер конструктора `updateViews` для `DefaultDataObjectEdmModelBuilder`:
Copy link
Contributor

@Anisimova2020 Anisimova2020 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как-то странно звучит. У нас же OdataService допускает довольно вольную инициализацию. Плюс юилдер может быть переопределённый.

Copy link
Contributor Author

@turbcool turbcool Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А что странного? Мы же примеры пишем для стандартного сценария использования.

Anisimova2020
Anisimova2020 reviewed Jan 30, 2024
View reviewed changes
pages/products/flexberry-orm/odata-service/fo_update-view.ru.md Outdated

Атрибуты, мастера, детейлы, которые не включены в `UpdateView`, нельзя будет использовать в запросах на обновление объекта через OData. Кроме того, эти атрибуты, мастера и детейлы не будут загружены в бизнес-сервере. Несмотря на эти особенности, данная функция может дать прирост к производительности, особенно в случаях, когда объекты содержат множество детейлов.

### Использование
Copy link
Contributor

@Anisimova2020 Anisimova2020 Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно подготовить ссылку на github с примером использования.

Copy link
Contributor Author

@turbcool turbcool Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сначала надо принять ПРы #292, #293. Тогда я смогу дать прямую ссылку на UpdateViewsTestStartup.cs, хотя этот код просто оттуда был скопирован.

Anisimova2020
Anisimova2020 reviewed Mar 5, 2024
View reviewed changes
pages/products/flexberry-orm/odata-service/fo_update-optimization.ru.md
Copy link
Contributor

@Anisimova2020 Anisimova2020 Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вообще бы на эту статью ссылку откуда-то лучше добавить.

Copy link
Contributor Author

@turbcool turbcool Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть ссылка в flexberry-orm_sidebar

Anisimova2020
Anisimova2020 reviewed Mar 5, 2024
View reviewed changes
pages/products/flexberry-orm/odata-service/fo_update-optimization.ru.md

1. Глобальная настройка (для всех классов).Необходимо передать параметр `masterLightLoadAllTypes`=`true` в `DefaultDataObjectEdmModelBuilder`:
```csharp
var modelBuilder = new DefaultDataObjectEdmModelBuilder(assemblies, false, pseudoDetailDefinitions, masterLightLoadAllTypes: true);
Copy link
Contributor

@Anisimova2020 Anisimova2020 Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У нас не рекомендовано var. Поэтому из примеров лучше убрать.

Copy link
Contributor Author

@turbcool turbcool Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно? В документации 645 раз используется var.

@coderabbitai
Copy link

coderabbitai bot commented Oct 25, 2024

Warning

Rate limit exceeded

@TeterinaSvetlana has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between f89da64 and 4e6dc74.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anisimova2020 Anisimova2020 Awaiting requested review from Anisimova2020

At least 1 approving review is required to merge this pull request.

Assignees

@Anisimova2020 Anisimova2020

Labels

need review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@turbcool @Anisimova2020 @TeterinaSvetlana