-
Notifications
You must be signed in to change notification settings - Fork 45
Editing sensor timezone from UI #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: joshuaunity <[email protected]>
Documentation build overview
Show files changed (4 files in total): 📝 4 modified | ➕ 0 added | ➖ 0 deleted
|
Signed-off-by: joshuaunity <[email protected]>
Signed-off-by: joshuaunity <[email protected]>
Signed-off-by: JDev <[email protected]>
Signed-off-by: joshuaunity <[email protected]>
Signed-off-by: joshuaunity <[email protected]>
Signed-off-by: joshuaunity <[email protected]>
Signed-off-by: JDev <[email protected]>
|
Oddly, while testing, I'm getting a 405 Method Not Allowed on the PATCH sensor endpoint when editing the sensor in the UI. Also on main. I don't have an explanation yet. I guess it works for you @joshuaunity? Updates:
|
|
Thanks for the find. Knowing where the issue is now, I was able to fix it. |
Signed-off-by: joshuaunity <[email protected]>
…lexmeasures into feat/edit-sensor-timezone
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Flix6x
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I added a changelog entry and also made some modest UX improvements to the validation logic.
Description
This PR gives the functionality to edit a sensor's timezone from the UI. As well as the addition of validation for only correct timezones.
Look & Feel
Before

After

How to test
Open any sensor and modify the timezone in the form. Then confirm it edits successfully, as well as validates correctly
Further Improvements
Maybe test cases?
Related Items
This PR closes #1486
Sign-off