-
Notifications
You must be signed in to change notification settings - Fork 45
feat: allow plugins to register forecasters #1863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F.N. Claessen <[email protected]>
Documentation build overview
Show files changed (12 files in total): 📝 12 modified | ➕ 0 added | ➖ 0 deleted
|
…-plugins-register-forecasters
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
BelhsanHmida
requested changes
Jan 7, 2026
Contributor
|
LGTM tested it out in a plugin and ran the forecasting cli command. the forecasting source was registered: type: forecaster
==========
ID Name User ID Model Version
---- --------------------------- --------- ----------------------------------------------- ---------
579 FlexMeasures COPForecasterone small suggestion in example class. |
Co-authored-by: Mohamed Belhsan Hmida <[email protected]> Signed-off-by: Felix Claessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forecastersubclasses defined in pluginsdocumentation/changelog.rstLook & Feel
In the hypothetical
my-first-emsplugin, withinmy_first_ems.data.models.heating:After registering the
my-first-emsplugin inflexmeasures.cfg:and it would be picked up when selected using
flexmeasures add forecasts --forecaster COPForecaster.How to test
Copy-paste the above class into plugin code and run
flexmeasures show forecastersto check that it shows up.Further Improvements
TrainPredictPipeline. Here, we usema.Schema(unknown="include")to accept any field. Both the API and CLI should validate fields using the schemas of the desiredForecastersubclass, rather than always using the schemas of theTrainPredictPipeline.Forecastersubclass itself is responsible for saving the data and creating jobs. That should probably be handled by a data service instead, similar to how it's handled forSchedulersubclasses.Related Items