Merged
Conversation
Merged
1 task
emyller
reviewed
Nov 20, 2025
There was a problem hiding this comment.
- Although the fix looks solid, is it relevant to get
Environment.nameavailable in the old engine? - Does this affect other behavior in the new engine? If so, we'll need to coordinate a team effort to update other SDKs. 😞
P.S. I also fixed "environment.name" in the fixture for the PHP client in order to map it correctly to the context, but didn't bother to make it useful in the old engine because seemingly it never was?
emyller
approved these changes
Nov 20, 2025
emyller
left a comment
There was a problem hiding this comment.
Approving because my previous questions aren't blockers.
Contributor
Author
|
The way I see it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment.name was wrongly mapped.
Added tests to mappers