-
Notifications
You must be signed in to change notification settings - Fork 18
Feat/compatibilty_with_riverpod3 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dorklein
wants to merge
9
commits into
FirebaseExtended:main
Choose a base branch
from
dorklein:feat/compatibilty_with_riverpod3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e733054
Update cloud_firestore_odm to support Freezed 3.0.0 and latest depend…
dorklein a463de0
chore: Update cloud_firestore_odm and generator to version 1.2.0
dorklein dfa4066
chore: Update SDK constraints and dependencies for cloud_firestore_od…
dorklein fcd1361
chore: Bump version to 1.3.0 and upgrade dependencies for cloud_fires…
dorklein 6f29f11
Update README.md
dorklein 389b61d
refactor: Simplify test assertions and remove debug print statements
dorklein 46f0c38
Update packages/cloud_firestore_odm_generator/CHANGELOG.md
dorklein 074ff44
Merge branch 'feat/upgrade-analyzer8' of github.com:dorklein/firestor…
dorklein 6dabdaa
feat: Update code generation to use .firebase.dart files
dorklein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,12 +22,13 @@ generated code: | |
| dart run build_runner watch --delete-conflicting-outputs | ||
| ``` | ||
|
|
||
| This will generate files with the postfix of `.g.dart`, corresponding to the | ||
| This will generate files with the postfix of `.firebase.dart`, corresponding to the | ||
| file name of your model. For example: | ||
|
|
||
| - A model is defined within a file named `product.dart`. | ||
| - Code generation will create a file in the same directory named `product.g.dart`. | ||
| - Within the `product.dart` file, apply the part declaration (`part 'product.g.dart'`). | ||
| - Code generation will create a file in the same directory named `product.firebase.dart`. | ||
| - Within the `product.dart` file, apply the part declaration (`part 'product.firebase.dart'`). | ||
| - You should also have a `.g.dart` for the json serilizer (`part 'product.g.dart'`). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| ## Next steps | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,18 @@ | ||||||
| ## 2.0.0 | ||||||
| - **BREAKING**: Must include a "part '<FILENAME>.firebase.dart';" instead of just part "'<FILENAME>.g.dart';". This is because of compatibilty with Riverpod ^3. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typo here. It should be
Suggested change
|
||||||
|
|
||||||
| ## 1.3.0 | ||||||
| - **CHORE**: upgraded packages to support analyzer ^8 and min sdk to 3.8.0 | ||||||
|
|
||||||
| ## 1.2.0 | ||||||
| - **CHORE**: Update cloud_firestore to ^6.0.0 | ||||||
|
|
||||||
| ## 1.1.0 | ||||||
|
|
||||||
| - **FIX**: Resolve compatibility issues with Freezed 3.0.0 and above | ||||||
| - **FEAT**: Support analyzer 7.0.0 and above | ||||||
| - **CHORE**: Update dependencies to latest versions | ||||||
|
|
||||||
| ## 1.0.0-dev.88 | ||||||
|
|
||||||
| - **BREAKING**: Removes `set` methods from `FirestoreDocumentReference` to make way for generated methods | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This manual step of modifying
pubspec.yamlfor local testing is error-prone, as a developer might forget to revert the changes before creating a pull request or publishing. This could lead to a broken release with a local path dependency. Consider automating this with a script or using a more robust solution for managing local dependencies in a monorepo, such as Melos, to mitigate this risk.