Add EncryptReader #646
Open
Add EncryptReader #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
encrypt-reader
branch
2 times, most recently
from
bf2ee21 to
0962d50
Compare
Add EncryptReader function to encrypt io.Reader (pull-based encryption) and use it in command to get rid of io.Copy. Updates FiloSottile#644 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
encrypt-reader
branch
from
0962d50 to
f53ab87
Compare
|
This PR is nice and we need it, would it make sense to add this? func EncryptStream(src io.Reader, recipients ... Recipient) (dst io.Reader, error) {
pr, pw := io.Pipe()
return pr, EncryptReader(pw, src, recipients...)
}We wrap it currently as: https://gitlab.com/data-custodian/custodian/-/blob/88e7389ec5b837672f2b76fd82aaed68a4145e72/components/lib-common/pkg/crypto/reader.go |
I think this won't work as writes to pipe will block without corresponding reads. |
|
This PR adds a handy function but what you are looking for is the implementation of #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EncryptReader function to encrypt io.Reader (pull-based encryption) and use it in cmd/age to get rid of io.Copy.
Updates #644