Add missing _requireTypeIdForSubtypes in StdTypeResolverBuilder in Jackson 3
#3970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
force-pushed
the
add-missing-_requireTypeIdForSubtypes-handling-in-StdTypeResolverBuilder
branch
from
17fdc2b to
0f84c17
Compare
JooHyukKim
deleted the
add-missing-_requireTypeIdForSubtypes-handling-in-StdTypeResolverBuilder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test failures in commit 2fea0d2
Root cause
There was missing part after couple of backport and forward-merges between branches
2.16andmasterHistory
First, we backported to 2.16 from master the
JsonTypeInfo.Valueusage inTypeResolverBuilderwith PR #3949.At this point, none of 2.16 and master branch handled
_requireTypeIdForSubtypesinStdTypeResolverBuilder👉🏼 Then, we introduced in 2.16 only
_requireTypeIdForSubtypesinStdTypeResolverBuilderwith PR #3953. So there definitely was confusion regards to whether #3953 was a feature or a backportHope it all makes sense 🙏🏼🙏🏼