Skip to content

[Proposal] Add MoveActionWrapper - #456

Open
younik wants to merge 6 commits into
Farama-Foundation:mainfrom
younik:master
Open

[Proposal] Add MoveActionWrapper#456
younik wants to merge 6 commits into
Farama-Foundation:mainfrom
younik:master

Conversation

@younik

@younik younik commented Nov 19, 2024

Copy link
Copy Markdown

Description

Whenever I work with Minigrid with full observability, I find the action space more complicated than should be. I believe the action space makes sense for agent view observation, but not with full observability, where using the directions (like FrozenLake) is easier.

As I already coded it for myself, I find it easier to open a PR than an issue but feel free to close it if you believe it is not a common use case.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@younik Apologies for only looking at this now.
I have a couple of questions

  • For debugging, this looks good but for implementation usage, taking extra steps to redirect an agent will affect TimeLimit. Could we cheat the environment by modifying the base agent direction to the intented direction then step forward? Only a single step will be taken in this case.
  • Why is the else case, action - 1?

@jkterry1

jkterry1 commented Jul 6, 2026

Copy link
Copy Markdown
Member

@younik would you be willing to reply to Mark's comments when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants