[Proposal] Add MoveActionWrapper - #456
Open
younik wants to merge 6 commits into
Open
Conversation
pseudo-rnd-thoughts
requested changes
Jan 13, 2025
pseudo-rnd-thoughts
left a comment
Member
There was a problem hiding this comment.
@younik Apologies for only looking at this now.
I have a couple of questions
- For debugging, this looks good but for implementation usage, taking extra steps to redirect an agent will affect TimeLimit. Could we cheat the environment by modifying the base agent direction to the intented direction then step forward? Only a single step will be taken in this case.
- Why is the else case,
action - 1?
Member
|
@younik would you be willing to reply to Mark's comments when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever I work with Minigrid with full observability, I find the action space more complicated than should be. I believe the action space makes sense for agent view observation, but not with full observability, where using the directions (like FrozenLake) is easier.
As I already coded it for myself, I find it easier to open a PR than an issue but feel free to close it if you believe it is not a common use case.
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)