In the BlockedUnlockPickupEnv, interacting with an empty box deletes the box, and creates an unsolvable situation. - #447
Open
AdrianOrenstein wants to merge 7 commits into
Conversation
Member
|
Thanks for the PR, could you provide a test for show this example of the box disappearing. This doesn't seem to be the correct solution, I would be trying to solve that rather than the current solution |
Member
|
@AdrianOrenstein I know its awhile later, but would you be willing to make the changes that pseudornd requested? |
Member
|
This would change the learning behavior so the version of the environment would need to be bumped everywhere, yes? |
Author
Yes. |
Member
|
Could you please do that version bump in this PR then?
…-------- Original Message --------
On Monday, 07/06/26 at 02:44 Adrian Orenstein ***@***.***> wrote:
AdrianOrenstein left a comment [(Farama-Foundation/Minigrid#447)](#447 (comment))
> This would change the learning behavior so the version of the environment would need to be bumped everywhere, yes?
Yes.
—
Reply to this email directly, [view it on GitHub](#447?email_source=notifications&email_token=AEUF33CSXF4PL7A6EGAKVML5DNDEBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBYHE4DKNRWGE42M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4889856619), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AEUF33DCBKQTNDV6QOBBMFL5DNDEBAVCNFSNUABFKJSXA33TNF2G64TZHMYTCNBRGQZTCOBSHNEXG43VMU5TENBYGU3TGOBUGQ3KC5QC).
You are receiving this because you commented.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR concerns a sequence of actions in the BlockedUnlockPickupEnv environment that will make an unsolvable situation in this environment. This environment requires the player to first move the obstacle out of the way, unlock the door, and then pick up the box. If instead, the agent interacts with the box and does not pick up the box, the box will be replaced with a None object and the box is subsequently deleted. In this environment, if the box is deleted by interacting with the box, the environment becomes unsolvable.
If this environment becomes unsolvable, the level and will require a reset or timeout. This PR changes the toggle behaviour of boxes to do nothing if the box is empty, preventing an agent from accidentally deleting boxes and creating an unsolvable situation.
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)