Skip to content

Fix doc "Create Custom Feature Extractor", normalized_images - #401

Open
riiswa wants to merge 4 commits into
Farama-Foundation:mainfrom
riiswa:patch-1
Open

Fix doc "Create Custom Feature Extractor", normalized_images#401
riiswa wants to merge 4 commits into
Farama-Foundation:mainfrom
riiswa:patch-1

Conversation

@riiswa

@riiswa riiswa commented Sep 18, 2023

Copy link
Copy Markdown

Description

I don't think that the current way indicated in the documentation is the right way to prevent stable-baselines3 from normalizing the images. I've updated the documentation, with a version that works (I've tested it).

If needed, I can create an issue, and link it to this PR.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BolunDai0216 Is this correct?

@jkterry1

jkterry1 commented Jul 6, 2026

Copy link
Copy Markdown
Member

@riiswa I'm starting to review this PR, could you please fix CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants