Skip to content

Check global lock time variable for bid withdrawal. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmpike wants to merge 2 commits into
base: developv2
Choose a base branch
from
Open

Check global lock time variable for bid withdrawal. #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e47c988
Check global lock time variable for bid withdrawal.
Dec 2, 2021
ec86991
Fix error response typo in auction bid withdraw.
Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/FantomAuction.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ contract FantomAuction is
uint256 public minBidIncrement = 1;

/// @notice global bid withdrawal lock time
uint256 public bidWithdrawalLockTime = 20 minutes;
uint256 public bidWithdrawalLockTime = 12 hours;

/// @notice global platform fee, assumed to always be to 1 decimal place i.e. 25 = 2.5%
uint256 public platformFee = 25;
Expand Down Expand Up @@ -394,8 +394,8 @@ contract FantomAuction is

require(
_getNow() > _endTime &&
(_getNow() - _endTime >= 43200),
"can withdraw only after 12 hours (after auction ended)"
(_getNow() - _endTime >= bidWithdrawalLockTime),
"can not withdraw before auction lock time"
);

uint256 previousBid = highestBid.bid;
Expand Down