Improve fairparamlist #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbx
reviewed
Apr 6, 2020
MohammadAlTurany
approved these changes
Apr 6, 2020
Closed
Member
Author
|
Okay. I reopen this one to comment of the comments. Thanks for information that it is meanwhile possible to changes the branch after creating the pull request. I was not aware of the possibility. |
Previously the parameters were stored in a TList. While this is okay for a small number of entries which are accessed by the function FindObject with the name of the object as argument this be becomes very slow when the list is large. Since for each entry of the list a search has to be performed this is time consuming when the list is long. To improve the performance a more suitable data structure (THashTable) was choosed to speed up the searching. The new data strcuture speeds up the initilization a CBM parameter container with roughly 101000 parameters by a factor of 5 from 145s to 27s. Since it is unavoidable to remove the searching it becomes obvious to limit the number of parameters in a parameter container to a small number.
For the proper functioning of the macro it is necessary to request the paramter container before calling the Init fucntion of the FairRun class. If this isn't done the parameter container is not properly filled but is only default constructed. Add comments to make intention of the macro more clear.
Remove data memmber fLogger* which is a remainder of old times. Use THashTable instead of THashTable*. Bump version of the ClassDef counter.
fuhlig1
force-pushed
the
improve_fairparamlist
branch
from
3731af1 to
0d7099f
Compare
Member
Author
|
Failing test should be unrelated. @dennisklein Is there a way o restart a test run on a specific node or is it needed to start the CI on all test machines? |
Member
|
Only a restart per test stage is possible. but we have only one stage, that means effectively to restart all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of FairParamList.
Detailed description is found in the commit message.
devbranch